Metrics, Thermal, Updates and Fixes

leppott / BioMonTools

Tools for biomonitoring and bioassessment; metric calculation for benthic macroinvertebrates, fish, and periphyton.

https://leppott.github.io/BioMonTools/

MIT License

13 stars 5 forks source link

Closed leppott closed 2 years ago

leppott commented 2 years ago

Describe the bug Updates to metrics in BioMonTools - Thermal.

change 'inconclusive' to 'cowa' (or some abbreviation of cool/warm…cowa is a distinct thermal group from cool and warm)
fix the pt_ti_stenocold_cold_cool metric – it is not including ‘cool’ (it only counts stenocold + cold). The nt and pi metrics are fine.
change the cool_warm metrics (nt, pt, pi) to cowa + warm + stenowarm

To Reproduce

Expected behavior

Additional context

leppott commented 2 years ago

[x] change 'inconclusive' to 'cowa' (or some abbreviation of cool/warm…cowa is a distinct thermal group from cool and warm)
[x] fix the pt_ti_stenocold_cold_cool metric – it is not including ‘cool’ (it only counts stenocold + cold). The nt and pi metrics are fine.
[x] change the cool_warm metrics (nt, pt, pi) to cowa + warm + stenowarm

leppott commented 2 years ago

No "inconclusive" in example data set so didn't have to change to "cowa".

leppott commented 2 years ago

bullet three change name and contents.

leppott commented 2 years ago

All tests for benthic metrics and metric names (tests/testthat/test_metric_names.R).