Change "Site_Type" and "Index_Region" to "Index_Class"

leppott / BioMonTools

Tools for biomonitoring and bioassessment; metric calculation for benthic macroinvertebrates, fish, and periphyton.

https://leppott.github.io/BioMonTools/

MIT License

13 stars 5 forks source link

Change "Site_Type" and "Index_Region" to "Index_Class" #83

Open leppott opened 2 years ago

leppott commented 2 years ago

Is your feature request related to a problem? Please describe. Have used Site_Type and Index_Region in multiple places between BioMonTools and BCGcalc packages.

Change to "Index_Class"

Describe the solution you'd like Will need to deprecate the input parameter in files.

Describe alternatives you've considered Need consistency between packages.

Additional context Will have to change:

functions (input parameters)
examples
example files.
vignettes
other?

leppott commented 2 years ago

[x] ext\DataBenthos.xlsx
[x] ext\MetricFlags.xlsx
[x] ext\MetricScoring.xlsx
[x] qc_checks.R
[x] metric_values.R
[x] metric_values_excel.R
[x] metric_scores.R
[x] data.R
[x] data-raw\data_benthos_MBSS
[x] data-raw\data_benthos_PacNW
[x] data-raw\data_diatom_mmi_dev
[x] data-raw\data_diatom_mmi_qc
[x] data-raw\data_fish_MBSS
[x] data-raw\metval_SCMB_IBI
[x] data-raw\data_mmi_dev
[x] vignette
[ ] Shiny,

leppott commented 2 years ago

Calculation slower. Will need to fix.

Modified mutate, if_numeric, replace_na statement to use a data frame and not a tibble. The grouping was making it take minutes instead of < 2 seconds.