leppott / BioMonTools

Tools for biomonitoring and bioassessment; metric calculation for benthic macroinvertebrates, fish, and periphyton.
https://leppott.github.io/BioMonTools/
MIT License
13 stars 5 forks source link

Add metrics for MN BCG and MMI (bugs and fish) #92

Closed leppott closed 2 months ago

leppott commented 1 year ago

Is your feature request related to a problem? Please describe. Add any metrics needed for MN BCG and MMI.

Describe the solution you'd like Add just what is needed.

Describe alternatives you've considered NA

Additional context Be sure to include in extdata/MetricNames.xlsx

leppott commented 1 year ago

Bugs

Fish

leppott commented 1 year ago

pt metrics need nt metrics of the same type.

leppott commented 1 year ago

Other metrics:

Bug

leppott commented 1 year ago

Fixed result of -Inf with extra max(0, ...) statement in calculation in metrics.R but still get warning of the initial -Inf.

It is because no taxa with that attribute.

image

leppott commented 1 year ago

Modify dom section to remove any NA before calculate metrics to avoid the -Inf warning image

Remove extra max() since still were getting -Inf warning even though not in the output.

leppott commented 10 months ago

Added fish metrics but left 1236sp metrics (n=3) as NA.

leppott commented 4 months ago

Add links to commits referencing issue. Forgot to add to NEWS and to commit so auto updates.

https://github.com/leppott/BioMonTools/commit/a36dbf9edff921f9a64146e18c1aab7eebfca17e

https://github.com/leppott/BioMonTools/commit/1353bbe922335dd4ff069e4692f1a9c2fba27644

https://github.com/leppott/BioMonTools/commit/7dcdfa6efdc9212b0985f059387b6dc003189976

https://github.com/leppott/BioMonTools/commit/fddfaf0ab4222bf5da3a6083264b9485ea2ac07d

https://github.com/leppott/BioMonTools/commit/930f5a10382143487abadb36bfe71993102f5262

https://github.com/leppott/BioMonTools/commit/1c9068b54a931538964cc9b601c4e806aabeec7c

https://github.com/leppott/BioMonTools/commit/e90fd8582db0b8dcedd60a294cef048b88eb9009

https://github.com/leppott/BioMonTools/commit/73d0a09885fd86695401b417209c0de03bbeb97c

https://github.com/leppott/BioMonTools/commit/f5113820373ac6f91093782eaa010882ef12cd45