search

leppott / ContDataQC

Quality control checks on continuous data. Example data is from a HOBO data logger with 30 minute intervals.
https://leppott.github.io/ContDataQC/
MIT License
20 stars 10 forks source link

USGS gage data download not working #150

Closed leppott closed 12 months ago

leppott commented 12 months ago

Describe the bug Email from user on 2023-08-02:

I am xxxx and I am a PhD student at University of xxxxxx. I am trying to use ContDataQC in R but I am having difficulty ...... I am also having difficulties pulling in gage data from USGS. Do you have any suggestions? I am using the newest version 4.3.1 (2023-06-16). Do I need to use an older version of R?

Creating two tickets from email. Only working with USGS gage data download.

To Reproduce Steps to reproduce the behavior:

  1. using R v4.3.1 (latest)
  2. Install from GitHub (code below).

if(!require(remotes)){install.packages("remotes")} #install if needed remotes::install_github("leppott/ContDataQC", force = TRUE)

To get USGS gage data use the console or the Shiny.

Console:

  1. Run the help file for ContDataQC
  2. Run the example down to step 01.A Get Gage Data.

(Works fine).

image

Shiny:

  1. Run Shiny
  2. Use the Gage data tab to get data.

Expected behavior A clear and concise description of what you expected to happen.

Additional context Also need to test what is hosted on ShinyApps.io.

leppott commented 12 months ago

Running download USGS gage data from Shiny app (from console) with the same inputs as the example.

image

After data is retrieved get download button.

image

The file name in the zip file has the gage ID and start/end dates.

image

And the file looks ok.

If use Shiny App from web () with the same inputs:

https://tetratech-wtr-wne.shinyapps.io/ContDataQC/

Worked as intended. When the app is working get progress in an pop up in lower right.

image

leppott commented 12 months ago

Splitting issue in to two tickets. One for the vignette and one for the USGS gage data.

leppott commented 12 months ago

Closing ticket as could not replicate issue.

The app will crash if a bad USGS gage ID is provided.

In this example I removed the leading zero from the gage ID.

image