leppott / ContDataQC

Quality control checks on continuous data. Example data is from a HOBO data logger with 30 minute intervals.
https://leppott.github.io/ContDataQC/
MIT License
20 stars 10 forks source link

formatHobo - not working #97

Closed leppott closed 3 years ago

leppott commented 3 years ago

Describe the bug One user with file that didn't work.

To Reproduce formatHobo() with the users file.

Expected behavior Should get a column for each.

Screenshots image

Additional context It is possible HOBO changed the file output format.

leppott commented 3 years ago

Example file that works.

image

User's Air file is missing "Air" in the name of the plot title and in the temperature column header.

leppott commented 3 years ago

Looking at the functions code:

  1. Cell A1 is ignored.

  2. SiteID and DataType come from filename.

  3. Air and Water Temp are looking for the words "Air Temp" and "Water Temp". Having just "Temp" is ambiguous and is not resolved.

Could potentially modify the routine for "Air" and "Water" files to assume "Temp" means "Air Temp" or "Water Temp" depending on the file type.

In the mean time, if add "Air" or "Water" to the Temp columns in the user's file it should work.

leppott commented 3 years ago

Column names that are searched for include:

leppott commented 3 years ago

Update function help file to be more explicit with the above text.

leppott commented 3 years ago

Do not think it is an issue with the HOBOware software. The function works after properly formatting the file.

Modified file image

Result image