Closed leppott closed 6 years ago
Made change from "WARM" to "HIGHLAND".
Confirmed pre-fix that FIBI not getting scores (n=30 in example). After fix all 30 had a score.
Fixed in v1.0.2.000.
https://github.com/leppott/MBSStools/commit/7e61dcfee7fc41898ef08f9aa4e791c62b5b5190
Email from DNR staff on 2017-10-26
Hi Erik,
I am attempting to calculate a FIBI using the package you developed and I found an issue in the metric.scores function, specifically line 181 of the scrip https://github.com/leppott/MBSStools/blob/master/R/metric.scores.R t:
myTF <- DF_Metrics[,IndexName]=="MBSS.2005.Fish" & DF_Metrics[,IndexRegion]=="WARM"
Basically, there is no "WARM" stratum, but rather a warmwater highland stratum, which we designate as "HIGHLAND". I think that changing that in the package script would fix the issues I'm having calculating a FIBI. Let me know what you think.
Thanks,
Jonathan