search

leppott / MBSStools

Suite of tools for data manipulation and calculations for Maryland DNR MBSS program.
https://leppott.github.io/MBSStools/
GNU General Public License v3.0
3 stars 3 forks source link

Consistency of variables, names and values #36

Closed leppott closed 3 years ago

leppott commented 3 years ago

Describe the bug Check for and ensure consistency of variable names and examples between functions. For example, Highland vs. Highlands.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior Should be the same across datasets and functions.

Screenshots NA

Additional context Add any other context about the problem here.

leppott commented 3 years ago

One of the last to do for 2021, there should be a log of the ones to change.

leppott commented 3 years ago

[] Only issue with Highland (correct) vs. Highlands (incorrect) is in strata designation.

[] The Exclude designation (True/False, Y/N, Y/[blank]) is the other place that discrepancies affect the function. From notes: In my current version, EXCLUDE=”TRUE” is the valid input. The database is a Y/blank system. Suggest leaving vignette as-is, and changing code to recognize “Y.”

leppott commented 3 years ago

Seems to only be an issue with PHI calculation. Ensure function and data are consistent with BIBI and FIBI.

image

Example data will need to be updated.

image

leppott commented 3 years ago

Update GIS files for strata function to match:

Highlands to Highland Piedmont to EPiedmont

leppott commented 3 years ago

strata now consistent in all locations (metric.scores, strata, and PHIcalc).

Highland, EPiedmont, Coastal, Cold

leppott commented 3 years ago

Changes for Excluded taxa were made in version v1.1.0.9021 https://github.com/leppott/MBSStools/commit/3a871ac554fd38777d4ae560d17bb33a99c003b0 and v1.1.0.9019 https://github.com/leppott/MBSStools/commit/e5cc6a11c826863c4c193f703fac04af60855a58