search

leppott / MBSStools

Suite of tools for data manipulation and calculations for Maryland DNR MBSS program.
https://leppott.github.io/MBSStools/
GNU General Public License v3.0
3 stars 3 forks source link

metric.scores - Family BIBI incorrect upper end of scale #45

Open leppott opened 5 months ago

leppott commented 5 months ago

Describe the bug Unlike genus BIBI the Family BIBI uses "greater than" instead of "greater than or equal" for its thresholds. The values entered in to the rules table did not adjust for this and values at the upper threshold are being scored a "5" instead of a "3".

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots

Metric thresholds from report.

image

Additional context Revised threshold values provided by MBSS staff.

image

Unlike the BioMonTools package that uses an Excel file the extdata folder the MBSStools package has the values in the package as an internal data file. Revise the .tab file and process data script in "data-raw" folder.

leppott commented 5 months ago

Added language to function help to reinforce that values used in the function are different from those in the published report due to the different mathematical operator used in the function.

image

code for scroing:

image

leppott commented 5 months ago

Need to QC then can close.

image