search

leppott / XC95

Extirpation analysis (XC95) for benthic macroinvertebrates and fish for environmental variables.
https://leppott.github.io/XC95/
0 stars 2 forks source link

fish.wt.cdf #7

Open leppott opened 6 years ago

leppott commented 6 years ago

Several issues.

  1. Not generic enough. Some variables still hard coded into the function (e.g., always wants 3 groups and they are HUC, EcoRegion, and WS Area).

  2. Function name should lose the "fish" name. Will keep fish.wt.cdf but will hide it.

  3. Includes a subdirectory.

  4. Not every parameter should be defaulted. The data files especially.

leppott commented 6 years ago

Added error checking for SampleID for presence in both input data frames.

leppott commented 6 years ago

Removed "keywords"

leppott commented 6 years ago

Fixed example, WS_Area vs. WS_AREA, in fish.wt.cdf.

https://github.com/leppott/XC95/commit/68a2cfac37f2ee15a62ee4d934d9d59b68de051a

v0.0.1.9003

leppott commented 6 years ago

Updated as v0.0.2.0000

https://github.com/leppott/XC95/commit/f2526cacbb5580f874d7e8ad1ef6f1115740aca6

leppott commented 6 years ago

Need to "hide" fish.wt.cdf with keyword internal.

That way user's code will still work but new users will not be using the "old" function.