Missing Char type - Githubissues

leptonyu / odpic-raw

Haskell raw bindings to Oracle ODPI-C Library

BSD 3-Clause "New" or "Revised" License

18 stars 5 forks source link

Closed mulderr closed 6 years ago

mulderr commented 6 years ago

Hello!

I see Char is missing from DataValue. The other types seem to be there, more or less.

I would somewhat expect odpic-raw to fairly closely follow upstream so I'm confused. Should Char be represented there?

leptonyu commented 6 years ago

@mulderr Thanks. I'll add DataChar in DataValue. Maybe later I should refactor DataValue to use Oracle raw types.

leptonyu commented 6 years ago

@mulderr I'm done. please check the change.

mulderr commented 6 years ago

Nice. Looks good. I'm hoping to find time to actually test it this weekend. Thanks!

leptonyu commented 6 years ago

Next PR, I'll use odpic raw data in DataValue, and provide a converter to convert to haskell data.