search

leptos-rs / book

The home for the Leptos book, which can be found deployed at https://book.leptos.dev
MIT License
89 stars 68 forks source link

Fix typo: change 'memoizes' to 'memorizes' in 06_control_flow.md #104

Closed NCura closed 4 months ago

NCura commented 6 months ago

Description

Hello, this is my first time contributing to open-source, and I'm excited to be able to help out!

I found a typo in the 06_control_flow and have submitted a pull request to fix it. I've changed the word 'memoizes' to 'memorizes'.

Additional Information

Please let me know if there's anything I can do to improve the changes or if there are any additional steps I need to take. I'm eager to learn and contribute more to the project.

Thank you for your time and consideration!

gbj commented 6 months ago

Thanks for the contribution! "Memoization" here isn't a typo for "memorization" but is a technical term for a certain kind of cached computation. Given that these are intro docs we should probably add a note clarifying that for others, as simply using an unknown term is not helpful to someone trying to learn!

NCura commented 6 months ago

🤦 good to know, thank you!

NCura commented 6 months ago

By the way, if I come across other potential typos while reading, should I create a separate pull request for each one, or should I wait until I've finished reading the book and submit a single pull request with a commit for each typo fix?

gbj commented 6 months ago

Making individual PRs as you go is great!