search

leptos-rs / book

The home for the Leptos book, which can be found deployed at https://book.leptos.dev
MIT License
59 stars 58 forks source link

Update 04_iteration.md #66

Closed ratulb closed 3 months ago

ratulb commented 4 months ago

Making sure that example code runs.

gbj commented 4 months ago

This is another example that follows the principle that the docs and examples default to the syntax enabled by the nightly feature, and that using the stable syntax requires a few small changes because on non-nightly, signals can't implement the Fn traits.

It's becoming clearer over time to me that we will need to rewrite the docs in the future to use the stable syntax by default, which makes me sad because I think it's worse than the nightly approach. I don't know that changing one instance is the right way to do that, although it may be the case that we have adapted enough of the APIs that there are not other places that are broken in the docs.

ratulb commented 4 months ago

Thanks for the clarification. I am on latest stable and overlooked that the example might be based on nightly.

From: Greg Johnston @.> Sent: Saturday, February 17, 2024 12:16 AM To: leptos-rs/book @.> Cc: Ratul @.>; Author @.> Subject: Re: [leptos-rs/book] Update 04_iteration.md (PR #66)

This is another example that follows the principle that the docs and examples default to the syntax enabled by the nightly feature, and that using the stable syntax requires a few small changes because on non-nightly, signals can't implement the Fn traits.

It's becoming clearer over time to me that we will need to rewrite the docs in the future to use the stable syntax by default, which makes me sad because I think it's worse than the nightly approach. I don't know that changing one instance is the right way to do that, although it may be the case that we have adapted enough of the APIs that there are not other places that are broken in the docs.

— Reply to this email directly, view it on GitHubhttps://github.com/leptos-rs/book/pull/66#issuecomment-1949102180, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAM3HOYHSEXE5TENAB7AMW3YT6SPDAVCNFSM6AAAAABDJLQSQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBZGEYDEMJYGA. You are receiving this because you authored the thread.Message ID: @.***>

ratulb commented 4 months ago

Hi Greg,

I was looking at Appendix section - Do you think there is a typo there? Please have a look at the attachment.

[cid:2caf6217-d200-4464-b7ad-e02d377e08ae]

From: Greg Johnston @.> Sent: Saturday, February 17, 2024 12:16 AM To: leptos-rs/book @.> Cc: Ratul @.>; Author @.> Subject: Re: [leptos-rs/book] Update 04_iteration.md (PR #66)

This is another example that follows the principle that the docs and examples default to the syntax enabled by the nightly feature, and that using the stable syntax requires a few small changes because on non-nightly, signals can't implement the Fn traits.

It's becoming clearer over time to me that we will need to rewrite the docs in the future to use the stable syntax by default, which makes me sad because I think it's worse than the nightly approach. I don't know that changing one instance is the right way to do that, although it may be the case that we have adapted enough of the APIs that there are not other places that are broken in the docs.

— Reply to this email directly, view it on GitHubhttps://github.com/leptos-rs/book/pull/66#issuecomment-1949102180, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAM3HOYHSEXE5TENAB7AMW3YT6SPDAVCNFSM6AAAAABDJLQSQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBZGEYDEMJYGA. You are receiving this because you authored the thread.Message ID: @.***>