search

leptos-rs / book

The home for the Leptos book, which can be found deployed at https://book.leptos.dev
MIT License
80 stars 61 forks source link

Fix ordered list numbering in SSR modes page #90

Closed yasutakekazu closed 4 months ago

yasutakekazu commented 6 months ago

Fixed ordered list numbering in SSR modes page!

gbj commented 6 months ago

Using numbers like

1.
1.
1.

in Markdown should cause them to be rendered correctly, without needing to fix/update the numbering if an item is inserted earlier in the list. Here's how it shows in the deployed version, for me -- Are you seeing something different?

Screenshot 2024-04-05 at 2 09 18 PM

yasutakekazu commented 6 months ago

You're right, and I see the same rendering with the numbered list as you do. Other Markdown files in the project use sequential numbering, and it didn't seem intentional that this file alone used repeated '1's. I agree that Markdown's auto-numbering is a clear advantage, saving manual effort. If this is by design, I understand and feel free to close this PR. I appreciate your consideration.

yasutakekazu commented 4 months ago

It's not good to leave it open.