Closed anvlkv closed 6 months ago
Wow! That looks really nice.
No worries, happy to be of help :)
Thank you!
Hi, I see that it stopped inserting the template since the class name changed...
Has to be updated in the sandbox.js
as well https://github.com/leptos-rs/book/pull/95/files#diff-f7e2d2c7fe483804ec618762331b0ca33fa535b68c06fd41944298e093c4c4a7R2
Or maybe I missed something?
On https://book.leptos.dev/view/01_basic_component.html it appears without the 'admonition-sandbox' class.
Seems like it's using the admonish-note styling too instead of the new admonish-sandbox
How it looks running latest main branch locally (looks correct):
How it looks on https://book.leptos.dev/view/01_basic_component.html
Ohh! The github action is using mdbook-admonish v0.14.0 and custom directives were added in v0.15.0. Probably just need to update that in the action here: https://github.com/leptos-rs/book/blob/40774ab8b5e563253380e23e3c73761cff07fc1c/.github/workflows/publish_mdbook.yml#L43-L46
Oeps, didn't know.
I hope you can update it
Opened a PR here: #96
Actually Greg got it at the same time: https://github.com/leptos-rs/book/pull/97 :heart:
This PR adds custom admonition for
mdbook-admonish
, addressing the #1It can be used in the book like this: