Closed tyoeer closed 8 months ago
Had to temporarily remove my own target-dir
configuration to make it match the CI, but the tests look like they should match what the CI is expecting now.
As a general comment, could you please include a sample dev experience walkthrough of how to leverage these improvements? This way I don't have to guess if I did the right set up to verify changes are doing what they are intended to accomplish.
@aperepel
The easiest way to test everything would be to configure the target directory in the top-level cargo configuration in ~/.cargo/config.toml
, for example with:
[build]
target-dir = ".cargo/targetShare"
This shares the target directory between projects. I personally do this to speed up compilation and save disk-usage by re-using already compiled dependencies (between projects), other people might have other reasons.
With this configuration, one would expect that:
target/server
, irregardless of the configured target directory, effectually overwriting your config for no apparent reason.wasm32-unknown-unknown
subfolder), and can reuse compiled dependencies
target/front
, with no way to configure/change it, , effectually overwriting your target directory config for no apparent reason.target/site
, irregardless of the configured target directory, effectually overwriting your config for no apparent reason.(Ideally there'd be a test demonstrating all this, but see my original PR comment for why I didn't manage to make one)
Hello, what's the status here? I've been using a binary compiled from this PR for quite some time now (without any issues) and I'd love to see this merged so I can use other updates as well. Is there anything I can help with? (code, testing, review, ...)
Sorry for the delay here — I've been reviewing PRs post-0.5 and am going to start going through these now.
No worries, thank you
Changes:
target/server
andtarget/front
pathdiff
site-root
to the/site/
subfolder of the cargo target directorySome
inparse()
, but that would forcesSome
checks everywhere.Didn't manage to add additional regression tests:
.cargo/config.toml
from where cargo is invoked, and does not take the--manifest-path
into accountcwd
, though it'sn't used for thecargo metadata
call, and isn't set to the directory of the actual project/workspace being tested. I can't figure out what exactly it's supposed to do, and I don't feel confident doing something with it.Additional notes/things to look at that are outside the scope of this PR:
src/ext/path.rs