search

leptos-rs / cargo-leptos

Build tool for Leptos (Rust)
MIT License
315 stars 88 forks source link

Add linux-musl and linux-aarch64 prebuilt binaries to github releases #220

Open Sycrosity opened 6 months ago

Sycrosity commented 6 months ago

When attempting to use cargo-leptos in a musl environment (such as a locked down alpine linux docker image), or in a linux aarch64 environment (such as with asahi-linux on macos) it would be very helpful to prebuilt binaries to speed up build times and development.

benwis commented 6 months ago

When attempting to use cargo-leptos in a musl environment (such as a locked down alpine linux docker image), or in a linux aarch64 environment (such as with asahi-linux on macos) it would be very helpful to prebuilt binaries to speed up build times and development.

We're using cargo-dist, and unfortunately it supports non of these environments in it's latest version

In v0.0.5 the only properly supported choices are:

    x64 macOS: "x86_64-apple-darwin"
    x64 Windows: "x86_64-pc-windows-msvc"
    x64 Linux: "x86_64-unknown-linux-gnu"
    arm64 macOS (Apple silicon): "aarch64-apple-darwin" (support added in v0.0.4)

Future versions should hopefully introduce proper support for important targets like "musl linux".

So once they add it we'll be happy to add them

DenuxPlays commented 6 months ago

When attempting to use cargo-leptos in a musl environment (such as a locked down alpine linux docker image), or in a linux aarch64 environment (such as with asahi-linux on macos) it would be very helpful to prebuilt binaries to speed up build times and development.

We're using cargo-dist, and unfortunately it supports non of these environments in it's latest version

In v0.0.5 the only properly supported choices are:

    x64 macOS: "x86_64-apple-darwin"
    x64 Windows: "x86_64-pc-windows-msvc"
    x64 Linux: "x86_64-unknown-linux-gnu"
    arm64 macOS (Apple silicon): "aarch64-apple-darwin" (support added in v0.0.4)

Future versions should hopefully introduce proper support for important targets like "musl linux".

So once they add it we'll be happy to add them

cargo-dist supports musl when I am reading this correctly? https://github.com/axodotdev/cargo-dist/pull/483

DenuxPlays commented 6 months ago

Okay musl-support came in 0.4.0: https://github.com/axodotdev/cargo-dist/releases/tag/v0.4.0 and you are using 0.3.1

benwis commented 6 months ago

Okay musl-support came in 0.4.0: https://github.com/axodotdev/cargo-dist/releases/tag/v0.4.0 and you are using 0.3.1

Ah, those docs were out of date then. I will add musl support today

DenuxPlays commented 6 months ago

Okay musl-support came in 0.4.0: https://github.com/axodotdev/cargo-dist/releases/tag/v0.4.0 and you are using 0.3.1

Ah, those docs were out of date then. I will add musl support today

Ok thank you 😀

Sycrosity commented 6 months ago

Ah, those docs were out of date then. I will add musl support today

Thank you! Would there also be some sense to, instead of the current rather clunky url for the sh installer, to have a leptos.dev/sh url for downloading the script?

DenuxPlays commented 5 months ago

Any updates on this?

benwis commented 5 months ago

Which? We've added linux-musl, but cargo-dist does not support arm musl, so we’re still waiting.

On Wed, Jan 3, 2024, at 10:22 AM, Timon Klinkert wrote:

Any updates on this?

— Reply to this email directly, view it on GitHub https://github.com/leptos-rs/cargo-leptos/issues/220#issuecomment-1875784208, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVBTCO3HOWK4JIYMBGLL5TYMWOX3AVCNFSM6AAAAAA7RAA5M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZVG44DIMRQHA. You are receiving this because you commented.Message ID: @.***>

DenuxPlays commented 5 months ago

Which? We've added linux-musl, but cargo-dist does not support arm musl, so we’re still waiting. … On Wed, Jan 3, 2024, at 10:22 AM, Timon Klinkert wrote: Any updates on this? — Reply to this email directly, view it on GitHub <#220 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVBTCO3HOWK4JIYMBGLL5TYMWOX3AVCNFSM6AAAAAA7RAA5M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZVG44DIMRQHA. You are receiving this because you commented.Message ID: @.***>

Ah so half of the issue got resolved :) Thank you

DenuxPlays commented 5 months ago

https://github.com/axodotdev/cargo-dist/releases/tag/v0.6.0

I think they do now. Added support in v0.6.0 if I read this correctly. At least they publish a musl-aarch64 build. image

benwis commented 5 months ago

Interesting, I’ll have to check. If they added it it’s no trouble to include a binary for the next release

On Wed, Jan 3, 2024, at 10:49 AM, Timon Klinkert wrote:

https://github.com/axodotdev/cargo-dist/releases/tag/v0.6.0

I think they do now. Added support in v0.6.0 if I read this correctly. At least they publish a musl-aarch64 build. image.png (view on web) https://github.com/leptos-rs/cargo-leptos/assets/83671398/98f4ba52-7401-44ab-9163-d8b606fadd57

— Reply to this email directly, view it on GitHub https://github.com/leptos-rs/cargo-leptos/issues/220#issuecomment-1875814431, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVBTCN3QHXPNCDTXNTBW3TYMWR5HAVCNFSM6AAAAAA7RAA5M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZVHAYTINBTGE. You are receiving this because you commented.Message ID: @.***>

morenol commented 2 months ago

Have you have time to check this? I would like to be able to install cargo-leptos with cargo binstall on linux aarch64

benwis commented 2 months ago

It is technically supported I'm told, if we switch to a paid github action runner. So far I haven't felt like investing the time and money to set that up

DenuxPlays commented 2 months ago

It is technically supported I'm told, if we switch to a paid github action runner. So far I haven't felt like investing the time and money to set that up

I think you should wait until they release arm runner for everyone later that year