search

leptos-rs / cargo-leptos

Build tool for Leptos (Rust)
MIT License
315 stars 88 forks source link

respect return code of external test command #93

Closed eiswind closed 1 year ago

eiswind commented 1 year ago

https://github.com/leptos-rs/cargo-leptos/issues/90

This pr raises an error when the external test command returns anything other than 0.

That allows for e.g. a ci pipeline to fail when there have been tests failing.

I am happily awaiting a review !

eiswind commented 1 year ago

Maybe we should have a test case?

eiswind commented 1 year ago

I like your approach. Did run and fail on my ci :)

akesson commented 1 year ago

It looks like it passes on the ci here.

eiswind commented 1 year ago

Hehe I meant something different I guess. I used the new code to run a playwright test that fails and that did make my (hello-world) pipeline fail, which it did not do before the change.

akesson commented 1 year ago

Ahhhh now I understand 🤣

Ok, looks good. Thanks for the contribution