Cut rc1 release - Githubissues

leptos-rs / leptos_wasi

Leptos WASI Preview 2 integration, working with wasmcloud and possibly others

MIT License

9 stars 2 forks source link

Cut rc1 release #8

Open ogghead opened 1 week ago

ogghead commented 1 week ago

Hi folks, getting back to this and I noticed that the Leptos 0.7 integration for leptos-spin is having problems after #4 where versions of Leptos became mismatched. I would like to propose cutting an rc1 version of this crate so that templates can rely on that version until 0.7 full release. I am happy to complete this work if it makes sense to folks, but wanted to start a discussion either way! This would involve:

[x] Creating a PR to lock all versions of dependencies -- mostly by using "rc1" versions of Leptos crates but also by locking git crate versions to specific commits when necessary
[ ] Tagging this version and publishing to crates.io

Curious to hear thoughts on this!

raskyld commented 5 days ago

We could but I think you made one change that is in main on Leptos which we rely upon (I think re-exporting any_spawner or something like that, sorry I don't remember exactly)

benwis commented 5 days ago

I think releasing something tied to rc1 makes sense, assuming it has what you need. I can always do an rc2 if it doesnty

On Wed, Nov 20, 2024, at 1:07 PM, Enzo Nocera wrote:

We could but I think you made one change that is in main on Leptos which we rely upon (I think re-exporting any_spawner or something like that, sorry I don't remember exactly)

— Reply to this email directly, view it on GitHub https://github.com/leptos-rs/leptos_wasi/issues/8#issuecomment-2489543256, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVBTCNC7UCCA2U7L7RZXA32BT2ZJAVCNFSM6AAAAABSA7ZTMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBZGU2DGMRVGY. You are receiving this because you are subscribed to this thread.Message ID: @.***>

ogghead commented 5 days ago

We could but I think you made one change that is in main on Leptos which we rely upon (I think re-exporting any_spawner or something like that, sorry I don't remember exactly)

I think releasing something tied to rc1 makes sense, assuming it has what you need. I can always do an rc2 if it doesnt

Good points! https://github.com/leptos-rs/leptos/pull/3195 does add the feature-gated functionality that @raskyld created in any_spawner as a re-export in Leptos, which makes it easier for templates to pull in. For fully reproducible builds, having that in rc2 would be wonderful @benwis! This crate could also use a pinned commit of any_spawner to achieve reproducibility using rc1 too though

ogghead commented 3 days ago

Tentatively created an rc1 locked version PR