search

leptos-rs / start-axum

Starter template for use with the Leptos web framework and Axum.
The Unlicense
141 stars 26 forks source link

fileserv file_and_error_handler does not correctly invoke error_template #1

Closed Indrazar closed 1 year ago

Indrazar commented 1 year ago

Currently when requesting a file which is not available the 404 page is blank. This is due to error_template being called with None.

Relevant lines in fileserv.rs: https://github.com/Indrazar/start-axum/blob/main/src/fileserv.rs#L25 https://github.com/Indrazar/start-axum/blob/main/src/fileserv.rs#L30

Indrazar commented 1 year ago

Requesting http://127.0.0.1:3000/404 also results in a 200 (OK) rather than a 404.

Indrazar commented 1 year ago

Both the lack of 404 and the error handling will be fixed after this PR or something similar is pulled.

Indrazar commented 1 year ago

closed by 44191fc989e64691d28c5cea6d318d3f8b2bb094