fix: AttributeError: module 'importlib' has no attribute 'metadata'

lepture / authlib

The ultimate Python library in building OAuth, OpenID Connect clients and servers. JWS,JWE,JWK,JWA,JWT included.

https://authlib.org/

BSD 3-Clause "New" or "Revised" License

4.52k stars 452 forks source link

fix: AttributeError: module 'importlib' has no attribute 'metadata' #635

Closed zzz-heygen closed 6 months ago

zzz-heygen commented 6 months ago

fixing https://github.com/lepture/authlib/issues/617 What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

[x] You consent that the copyright of your pull request source code belongs to Authlib's author.

codespearhead commented 6 months ago

Can you link this PR to that issue ( #617 ), like this?

zzz-heygen commented 6 months ago

As long as you mentioned the number of the issue, Github can automatically link it. If you check the issue page, it says I am referencing the issue.

codespearhead commented 6 months ago

I'm afraid there's been a misunderstanding here. Referencing an issue is not the same as linking a PR to it, as can be seen in the lower right-hand corner of the page in desktop mode.

Mentioning the issue id will only automatically link a PR to it if it's preceded by a specific set of keywords, and "fixing" is not one of them. As per the documentation:

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. The pull request must be on the default branch.

close

closes

closed

fix

fixes

fixed

resolve

resolves

resolved

kravuri517 commented 6 months ago

Hi, any update on when this fix will be merged? Your assistance is greatly appreciated.