search

lepture / python-livereload

livereload server in python
https://livereload.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
1.02k stars 150 forks source link

Upload wheels to PyPI #240

Closed johnthagen closed 1 year ago

johnthagen commented 3 years ago

Wheels (.whl) for this package are currently missing from PyPI. Could wheels be uploaded for the current and future releases?

Read more about the advantages of wheels to understand why generating wheel distributions are important.

To create a wheel along with source distribution:

(venv) $ pip install --upgrade pip setuptools wheel
(venv) $ python setup.py sdist bdist_wheel

# See dist/*.whl

To upload wheels:

(venv) $ pip install twine
(venv) $ twine upload dist/*
johnthagen commented 3 years ago

It looks as though wheels used to be uploaded as recent as: https://pypi.org/project/livereload/2.6.1/#files

Did something change in the release procedures such that wheels are no longer being published?

McSinyx commented 3 years ago

I am curious as well.

pradyunsg commented 3 years ago

I'd be happy to do this, should @lepture provide me with the ability to uplaod on PyPI.

hugovk commented 2 years ago

@pradyunsg I see you're now listed as a maintainer on PyPI! 🚀

stevepiercy commented 1 year ago

Adding a wheel might silence the current deprecation notice.

DEPRECATION: livereload is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559

pradyunsg commented 1 year ago

Uploaded a wheel for 2.6.3.

That deprecation is related to the fact that you don't have the wheel package installed in the virtual environment you're building/installing this package in; and is more related to the fact that pip is gonna change its behaviour soon. :)

stevepiercy commented 1 year ago

Thanks. We'll add wheel to our requirements.

brianpeiris commented 1 year ago

FYI, this new WHL package broke our CI build because pip will use the new WHL package before it uses the old tar.gz package. Our build then failed because the SHA of the new package does not match the SHA in our requirements.txt generated by pip-compile.

It may not be best to try to undo this now (we've already updated to the new SHA), but please be careful when uploading new packages for old versions.