search

lequietriot / Old-School-RuneScape-Cache-Tools

The ultimate suite of Old School RuneScape Cache editing tools. Also supports most RS2, RSHD, & RS3 caches.
15 stars 5 forks source link

Changing Settings of the Music Player don't apply #1

Closed CypherNL closed 2 years ago

CypherNL commented 2 years ago

Version: 0.2.0 (Jar file)

If you change a value like the volume or sample rate value, the setting doesn't apply when pressing Enter or leaving the input field. I tested this by changing these values and then rendering a MIDI to a file. The sample rate is still the original and the volume has been unchanged.

It also seems the Music Player doesn't work sometimes after loading the cache with playing or exporting MIDI files to file, if iexport a MIDI file from the cache afterwards from example, then it will play the MIDI file and you can export it, although if you change a value, the changed value don't apply to the exported file when exporting again.

CypherNL commented 2 years ago

The value of the custom soundfont path also don't apply when pressing Enter or leaving the input field.

lequietriot commented 2 years ago

Version: 0.2.0 (Jar file)

If you change a value like the volume or sample rate value, the setting doesn't apply when pressing Enter or leaving the input field. I tested this by changing these values and then rendering a MIDI to a file. The sample rate is still the original and the volume has been unchanged.

It also seems the Music Player doesn't work sometimes after loading the cache with playing or exporting MIDI files to file, if iexport a MIDI file from the cache afterwards from example, then it will play the MIDI file and you can export it, although if you change a value, the changed value don't apply to the exported file when exporting again. The value of the custom soundfont path also don't apply when pressing Enter or leaving the input field.

@CypherNL version 0.3.0-beta should hopefully fix these issues, but if it is not fixed for you, please let me know.

CypherNL commented 2 years ago

It works as long you press enter after changing the value. Thanks!