search

lequietriot / music-mask

RuneLite Plugin that allows the user to play higher quality MIDI music over the Old School RuneScape game.
BSD 2-Clause "Simplified" License
8 stars 0 forks source link

Doesnt seem to do anything? #1

Open Jin-Jiyunsun opened 2 years ago

Jin-Jiyunsun commented 2 years ago

Is there supposed to be a music player or something on right hand side with all the runelite icons? Ive added in a custom soundfont but the plugin simply doesnt seem to do anything with it.

Trogdorbad commented 2 years ago

Yeah I'm having the same issue here. I changed the midi directory to the folder I have of old runescape midis, but is the filename system there causing issues? Are you supposed to make a MIDI folder in your downloads folder where the plugin auto-directs?

alowaniak commented 2 years ago

AFAICT the file-name (existing in the Default MIDI Music Path) needs to be the same as the track name (plus .mid). And you need to have the soundfont file at Default Custom SoundFont Path.

I've only downloaded the Runescape 2.sf2 and Start.mid from https://drive.google.com/drive/folders/1Dl3Q1kNx7ouYcDLJhqAUCZxd4ZliShM2 and haven't tried other soundfonts/midis. But it seems to work for me.

(To further elaborate on this: Newer commits seem like they try to get the midi data from the client instead of requiring a <track>.mid file. However that doesn't exist in the plugin-hub (nor is there a PR) yet.)

lequietriot commented 2 years ago

This plugin should be working as intended now, only if using the MacOS or Java version of RuneLite (I do not have Linux). For some reason the Windows version does not seem to load soundfonts. The plugin's path only requires the part after your user home directory (For example, the path could look like: Downloads/Custom.sf2).

And yes, the plugin now decodes music from the game's files directly rather than relying on local midi files. Let me know if you have any questions or thoughts, I will leave this issue open until the plugin is fully functional. Thank you!

Jin-Jiyunsun commented 2 years ago

still cant seem to get this to work, using the runescape 2.sf2 from the google drive link and when the plugin is active nothing plays