search

lerenn / asyncapi-codegen

An AsyncAPI Golang Code generator that generates all Go code from the broker to the application/user. Just plug your application to your favorite message broker!
Apache License 2.0
78 stars 21 forks source link

Feature/acks naks and errorhandling (#122) #163

Closed magraef closed 3 months ago

magraef commented 3 months ago

As discussed in #122 , I have implemented an ackowladgement with Ack/Nak for the broker implementation and added an errorhandler for subscribers.

magraef commented 3 months ago

@lerenn I will submit the tests and examples asap. Thanks for your review

magraef commented 3 months ago

@lerenn I have taken your advice on the last commits. The exception is the noop handler. I could not import it because of cycled imports. I have replaced it accordingly.

I am unsure whether the tests are correctly located under issue 122. Also the setup of the tests is currently not documented or? Maybe you have a better idea for the tests.

lerenn commented 3 months ago

Thanks for the incredible work ! 💯

Also the test is at the right place and with the correct setup, I will do a Contributing guide because it clearly lacks information on what should be done to contribute and, more specifically, how to test things.

I'll merge your MR ASAP ! Thanks again ☺️

lerenn commented 3 months ago

@magraef the PR is merge !

Thanks again for your work, that will be really useful for a lot of people 🙏

Feel free to continue contributing, either by code or by advice/critics ! I'll do a proper contributing guide in the next days :P