Whoistolu
commented
1 year ago Hi @JavierAybar and @lerfast
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!
Highlight
🔆 All cards are assigned 🔆 Groups tasks are assigned 🔆 All cards have a description
Required Changes ♻️
- [ ] Check the inline comments under the review for sections to improve.
- [ ] [REQUIRED] Kindly ensure that all cards are assigned to team members such that each card has an avatar of a team member the task is been assigned to. NB: All cards with
group taskin the title should be assigned to someone (it does not matter to whom it is assigned).
Your Cards
What it should look like (Correct card)
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
- [ ] [OPTIONAL] I would like to suggest that in the information provided about the number of people in the group, you could also add both team members' GitHub handles. This will make that look more professional.
Cheers, and Happy coding!
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @whoistolu in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
usorfaitheloho
https://github.com/lerfast/Capstone-module2-Javacript/tree/Initiate-project
Javier Aybar (@JavierAybar) and Luis Emilio Rojas (@lerfast) are part of the working team for this project.