lericson / pylibmc

A Python wrapper around the libmemcached interface from TangentOrg.
http://sendapatch.se/projects/pylibmc/
BSD 3-Clause "New" or "Revised" License
481 stars 137 forks source link

Does pylibmc support Python3.3? #146

Closed ohmeow closed 9 years ago

ohmeow commented 10 years ago

Having issues installing it on a Ubuntu server within a Python 3.3.2 project ... so just asking for information. Thansk

lericson commented 10 years ago

Yes, but not in any release yet, I'm afraid! Check out the py3k branch, there's an almost release-ready port.

On 25 apr 2014, at 19:31, Wayde Gilliam notifications@github.com wrote:

Having issues installing it on a Ubuntu server within a Python 3.3.2 project ... so just asking for information. Thansk

— Reply to this email directly or view it on GitHub.

ohmeow commented 10 years ago

Thanks for letting me/us know Ludvig. I'm fairly new to working on my own VPS, so I'm wondering if there are any instructions for building from the py3k branch so as to get things operational on my Ubuntu 13.10 server?

lericson commented 10 years ago

Quite possibly you would need a lot of the -dev stuff in Ubuntu, not sure myself as I don't use that particular distribution. Perhaps look into that, then get libmemcached installed, and finally the pylibmc py3k branch. Hope it works out!

lericson commented 10 years ago

Also, you will need the Python development headers.

eskhool commented 10 years ago

Ludvig, based on your own availability can you give an approximate time frame for the anticipated releasing the py3k version ...1/3/6 month etc...so we can plan around that? Already working as a core team member on a couple of other OS projects so don't have the bandwidth to jump in on pylibmc but it works great :+1:

lericson commented 10 years ago

Good question, @eskhool -- it's hard to say since there is no release schedule. I think the py3k branch is becoming feature-complete; what remains now is to test it and see that it works as it should. I would like to do this myself, but sadly I don't come into contact with Python 3.x too much :/

eskhool commented 10 years ago

@lericson ...Thanks for the update..I will be migrating a major project that relies on pylibmc with Django so it will see some degree of testing ...how about a label or convention for py3 issues to seperate them out

lericson commented 10 years ago

Sure, slap 'em on.

hfalcic commented 10 years ago

@eskhool For what it's worth, I've been using my pylibmc fork in production for few months as part of a Django (1.6) project. I haven't experienced any problems whatsoever.

jvc26 commented 10 years ago

WRT the 3.x merge, is there a PyPI release coming to include py3 support?

lericson commented 10 years ago

I would be happy to, but until I or somebody else gets the time to really test these changes I'm not confident enough in the product to release it.

koobs commented 10 years ago

@lericson Will running the test suite on Python 3.3 & 3.4 suffice?

lericson commented 10 years ago

It's a start!

We need to test the cartesian product of py{2.6,2.7,3.4,3.5} and libmemcached-{0.44,0.55,1.0.x}

On 8 jul 2014, at 17:59, koobs notifications@github.com wrote:

@lericson Will running the test suite on Python 3.3 & 3.4 suffice?

— Reply to this email directly or view it on GitHub.

lericson commented 10 years ago

Hey guys, I ran the test suite in Python 3.x during EuroPython but was unable to get the tests to pass. Any others with the same issue? Did you find a solution?

jvc26 commented 10 years ago

Would an addition to the travis-ci file (along the lines of http://docs.travis-ci.com/user/build-configuration/#The-Build-Matrix) enable a matrix build for the combinations?

lericson commented 10 years ago

It is certainly possible, but you'd have to make a builder script for libmemcached first. Travis CI bundles it for us, as it currently stands.

p-lewis commented 10 years ago

Hi, I made a travis-ci 2 x 2 matrix with Python 2.7, 3.4 and libmemcached 0.44, 1.0.8. I made a libmemcached PPA for the 1.0.8 environment.

Results: https://travis-ci.org/p-lewis/pylibmc My travis-ci yaml: https://github.com/p-lewis/pylibmc/blob/py3k/.travis.yml

Looks like python 2 is failing tests, and python 3 is not building.

Happy to continue working on this, but I'd like to know what I should do next. Submit a PR as is? Try and fix build errors? Thanks.

hfalcic commented 10 years ago

Your py3k branch is way behind -- you should test off of master. The failures you're seeing were fixed quite a while ago (the Python 3.4 build failure at the end of May, for instance).

p-lewis commented 10 years ago

@hfalcic thanks, I didn't realize the py3k changes were in master.

I've updated and run against master, and the 2x2 matrix is passing. https://travis-ci.org/p-lewis/pylibmc

I can build out the rest of the matrix shortly.

What version did you want for libmemcached 0.5x? I didn't see an 0.55, I see a 0.53.

https://launchpad.net/libmemcached/+download?memo=10&start=10

lericson commented 10 years ago

That's amazing, @p-lewis! Excellent work. All that stands in the way of a proper release now the problem of get_multi, #158.

lericson commented 10 years ago

And please do PR, I would think this to be issue hijacking ;)

hfalcic commented 10 years ago

The py3k branch has served its purpose, so I propose deleting it.

lericson commented 10 years ago

I agree, will do ASAP!

On 13 sep 2014, at 18:25, Harvey Falcic notifications@github.com wrote:

The py3k branch has served its purpose, so I propose deleting it.

— Reply to this email directly or view it on GitHub.

msabramo commented 10 years ago

So Python 3 support is in master and issue mentioned above, #158 is closed.

So is it time to do a release with Python 3 support?

Cc: @sontek @aconrad

sontek commented 10 years ago

I'm offering high fives for any Python 3 related release.

msabramo commented 10 years ago

I'll see @sontek's high fives and also throw in huge kudos.

sontek commented 9 years ago

beauller

hfalcic commented 9 years ago

In my opinion merging #167 is the only blocker.

reverie commented 9 years ago

@lericson What can people do to help you cut a py3-compatible release?

lericson commented 9 years ago

The answer to the original issue is now simply "yes".

Ho ho ho :santa: Merry christmas, everyone!

reverie commented 9 years ago

Best present ever. Thank you!

msabramo commented 9 years ago

Christmas came early this year!

:hand: :cake: :beer: :smile:

sbancal commented 9 years ago

Just in time (for my project, but still a bit early for christmas) ... Wow ... so great!!

koobs commented 9 years ago

!!!! \o/ I'll update the FreeBSD Port today