search

lericson / pylibmc

A Python wrapper around the libmemcached interface from TangentOrg.
http://sendapatch.se/projects/pylibmc/
BSD 3-Clause "New" or "Revised" License
478 stars 136 forks source link

Test on Travis CI with Ubuntu Xenial and Python 3.7. #250

Closed andreif closed 4 years ago

andreif commented 5 years ago

3.8-dev passes the tests, should we add it as well? or 3.8.0a1 feels too early?

lericson commented 5 years ago

Add it, why not!

On 24 Feb 2019, at 21:04, Andrei Fokau notifications@github.com wrote:

3.8-dev passes the tests, should we add it as well? or 3.8.0a1 feels too early?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

andreif commented 5 years ago

I managed to run tox only after changing the command to:

{toxinidir}/bin/with-memcached python {toxinidir}/bin/runtests.py {posargs:-v tests --with-doctest}

Using pyenv, I got all tests pass: 

$ pyenv shell tox 2.6.9 3.3.7 3.4.9 3.5.6 3.6.8 3.7.2 3.8-dev
$ tox
  ...
  py26: commands succeeded
  py27: commands succeeded
  py33: commands succeeded
  py34: commands succeeded
  py35: commands succeeded
  py36: commands succeeded
  py37: commands succeeded
  py38: commands succeeded
  congratulations :)
andreif commented 5 years ago

Btw, it would be great to push next release soon, so that #246 gets finally resolved.

andreif commented 5 years ago

I haven't managed to make tox running with pypy, but it works fine when I run tests directly (atm only 6.0.0 seems available via pyenv):

$ pyenv install pypy3.5-6.0.0
$ pyenv shell pypy3.5-6.0.0
$ pypy3 -m pip install nose
$ pypy3 -m pip install -e .

$ ./bin/with-memcached pypy3 ./bin/runtests.py -v tests --with-doctest
...
Ran 56 tests in 14.092s

OK
andreif commented 5 years ago

Well, if one forks pyenv, pushes new tag, modifies brew formula and installs from the fork, comes future a bit earlier:

  1. edit /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/pyenv.rb: 
    url "https://github.com/andreif/pyenv/archive/1.2.10.tar.gz"
sha256 "49b287efab80ac7c50c684cc7a0c549599603e37abf6af7cf0f5408b4e961265"
  2. install future pyenv 
    $ HOMEBREW_NO_AUTO_UPDATE=1 brew install pyenv
  3. install pypy 
    
$ pyenv install pypy3.5-7.0.0

Python 3.5.3 (928a4f70d3de, Feb 08 2019, 10:43:14) [PyPy 7.0.0 with GCC 4.2.1 Compatible Apple LLVM 10.0.0 (clang-1000.11.45.5)] on darwin

4. tests pass, pretty fast

Ran 51 tests in 9.862s OK


Btw, Travis runs an older version:

Python 3.5.3 (3f6eaa010fce, Jan 11 2018, 04:44:35) [PyPy 5.10.1 with GCC 6.2.0 20160901]

andreif commented 5 years ago

6.0.0 runs also fast, not sure why it took longer before. CPython 3.7 runs in 10.291s.

andreif commented 5 years ago

@lericson Hey, anything on your mind that stopping you from merging it? Just let me know where I need to look.

lericson commented 5 years ago

Wow, 10 seconds? I have to look into this more. Good job Andrei! Also hi 😄