search

lericson / pylibmc

A Python wrapper around the libmemcached interface from TangentOrg.
http://sendapatch.se/projects/pylibmc/
BSD 3-Clause "New" or "Revised" License
478 stars 136 forks source link

add py3.12 #286

Closed davidszotten closed 8 months ago

davidszotten commented 8 months ago

is anything else needed to get a python 3.12 wheel? thanks!

davidszotten commented 8 months ago

oh wow, that was quick. unfortunately i'm not sure this is enough. made a temp commit to test the wheel building https://github.com/davidszotten/pylibmc/actions/runs/6480516499/job/17596188708 and it's not building for 3.12. working to figure out why (unless you know?)

lericson commented 8 months ago

ISTM that cibuildwheel is what is actually creating per-version wheels, and it is not generating an artifact for Python 3.12.

lericson commented 8 months ago

According to its documentation:

⁵ CPython 3.12 is built by default using Python RCs, starting with cibuildwheel 2.15.

According to the build log:

Downloading cibuildwheel-2.13.1-py3-none-any.whl.metadata (22 kB)

I think it is because the CD script is using Python 3.7 and cibuildwheel is no longer being released for that ancient version.

davidszotten commented 8 months ago

thanks, was just discovering the same thing. since 3.7 is eol, what do you think about dropping support for it?

davidszotten commented 8 months ago

actually, maybe it's enough to stop building wheels for 3.7 (by running cibuildwheel on 3.8). testing that now. we may of course still want to stop supporting eol pythons

davidszotten commented 8 months ago

ok that seems to work. how does publishing work atm? the upload part is commented out in the workflow

lericson commented 8 months ago

I upload it manually