lericson / simples3

Simple, quick Amazon AWS S3 interface in Python
BSD 2-Clause "Simplified" License
96 stars 36 forks source link

python3 compatibility #19

Closed vukasin closed 3 years ago

vukasin commented 10 years ago

Hi, I needed this to run on Python3.4. Most of the changes are automatic 2to3 but some needed to be hand tuned (see bucket.py)

lericson commented 10 years ago

Pretty sure this is supposed to work out of the box

On 21 maj 2014, at 10:13, Vukasin Toroman notifications@github.com wrote:

Hi, I needed this to run on Python3.4. Most of the changes are automatic 2to3 but some needed to be hand tuned (see bucket.py)

You can merge this Pull Request by running

git pull https://github.com/vukasin/simples3 master Or view, comment on, or merge it at:

https://github.com/lericson/simples3/pull/19

Commit Summary

python3 compatibility File Changes

M .gitignore (12) M simples3/init.py (2) M simples3/bucket.py (51) M simples3/gae.py (12) M simples3/streaming.py (4) M simples3/utils.py (10) M tests/init.py (24) M tests/test_bucket.py (16) M tests/test_streaming.py (6) Patch Links:

https://github.com/lericson/simples3/pull/19.patch https://github.com/lericson/simples3/pull/19.diff — Reply to this email directly or view it on GitHub.

vukasin commented 10 years ago

well mostly it does. there are a few problems:

  1. the base64 in signing needs to be treated as binary as opposed to string (otherwise keys don’t work)
  2. there is a check for presence of the “iteritems” attribute which does not exist

I've added comments to the changes which are not generated by running 2to3