search

lericson / simples3

Simple, quick Amazon AWS S3 interface in Python
BSD 2-Clause "Simplified" License
96 stars 36 forks source link

Adds pagination support on S3Bucket.listdir #3

Closed kevinclark closed 13 years ago

kevinclark commented 13 years ago

We've got folders with 1000+ things. This change makes it so we can get to them without changing code.

lericson commented 13 years ago

I'm all for the idea behind this change, I should note - I would love to have a listdir() that spans multiple requests. I just don't think it's a good idea to mutilate an existing method so it suites other needs.

kevinclark commented 13 years ago

Doh, just saw your other reply. Got it. Will consider an alternative that doesn't modify already established methods.

kevinclark commented 13 years ago

Ok, how's this?

lericson commented 13 years ago

Sorry for not getting back to you; I've been ill and am catching up with a backlog of things I need to do, so I hope I have time to make a decision here as soon as possible.

kevinclark commented 13 years ago

No problem. I'm happy to continue tweaking if you think it needs it. For now, we've just been running out of our own branch.

lericson commented 13 years ago

Boy did you ever get me confused with having a different GitHub account from the one hosting the repository. :-D

Going to try and merge this now, stop by in #sendapatch on freenode if you want some IM action going.

lericson commented 13 years ago

Merge S3 listing changes from Greplin

Closed by 19a078b07bb04ea59216bcf7f158f9a62f19832d, and also includes the secure argument to S3Bucket.