search

lericson / simples3

Simple, quick Amazon AWS S3 interface in Python
BSD 2-Clause "Simplified" License
96 stars 36 forks source link

Support Multi-Object Delete #8

Closed dahlia closed 12 years ago

dahlia commented 12 years ago

Late last year AWS S3 announced Multi-Object Delete that allows to delete up to 1,000 objects with a single request.

This patch makes delete() method able to take one or more keys (up to 1,000) and fixes a trivial bug of authorization for sub-resource access.

I did want to write a documentation for it also, but I can’t find reStructuredText files.

lericson commented 12 years ago

I think this needs more thorough testing, please advise

dahlia commented 12 years ago

I tested it on my private S3 bucket, but I didn’t leave the used test code. Currently test codes create mock HTTP connections that emulate S3 buckets, but it seems to need also tests that don’t emulate anything but use real S3 buckets.

lericson commented 12 years ago

I agree it would be good to test against the real S3, and I used to do that for the longest time; the problem however is though that this requires we publicize a key pair and I'm certainly not going to do that.

For now these tests work well; applications themselves can test that the S3 connection works as it should.

Thanks for your contribution! You should probably be added some list of authors somewhere.

dahlia commented 12 years ago

We don’t have to publicize your key pair. Leaving a local test configuration file or using environment variables also can be considered.

Thank you!