lerna-stack / akka-entity-replication

Akka extension for fast recovery from failure with replicating stateful entity on multiple nodes in Cluster
Apache License 2.0
30 stars 1 forks source link

RaftActor shouldn't delete committed or non-conflict entries #151

Closed xirc closed 2 years ago

xirc commented 2 years ago

Closes https://github.com/lerna-stack/akka-entity-replication/issues/152

There might be two places to be able to fix this bug:

This PR changes AppendEntries handling to fix this bug. pros:

TODO

xirc commented 2 years ago

@negokaz As our team discussed, we have to fix this bug. Our team created a draft (not the exact same as this PR's code) fixing this bug and also verified this strategy might be the right direction. I've created a fix patch for this bug (is possible to merge but not unit-tested yet). Could you do a quick review of the code? I'm going to run the Gatling scenario and also write tests. I've already verified that existing tests pass.