Retrieve PR's for commits from new GitHub API

lerna / lerna-changelog

:book: PR-based changelog generator with monorepo support

MIT License

804 stars 100 forks source link

Retrieve PR's for commits from new GitHub API #157

Open rwjblue opened 5 years ago

rwjblue commented 5 years ago

GitHub introduced a new API for determining which PR a commit came from, we could use this API to avoid the multiple regular expression matchers that we are having to use today (e.g. the "squash and merge" style, the "merge commit" style, "homu", etc).

References:

simonihmig commented 3 years ago

This seems very useful, to make the detection stable.

I just played around with my IDE's (JetBrains) ability to interact with the Github APIs, in this case reviewing and merging a PR. Apparently it caused the merge commit to have a different message than usual:

The from part is missing from this regex, so didn't get any changelog information...

thibaultdalban commented 3 years ago

Could it allow to use lerna-changelog with PRs rebased and not only merged or squashed?