search

lerna / lerna-changelog

:book: PR-based changelog generator with monorepo support
MIT License
804 stars 100 forks source link

Doesn't work well with independent mode #26

Open hzoo opened 8 years ago

hzoo commented 8 years ago

Example below

Since each thing is independent it doesn't make sense to have a changelog entry per release since each one is seperate.

Changelog for 2016-08-31

Bug Fix

Turbo87 commented 7 years ago

@hzoo should independent mode generate changelogs per project instead of a global one?

hzoo commented 7 years ago

I'm not sure anymore lol

fahad19 commented 7 years ago

I feel it makes sense to generate changelogs per project (in independent mode).

evocateur commented 7 years ago

lerna publish --conventional-commits supports per-project changelogs in --independent mode, though admittedly not from lerna-changelog directly.

sthzg commented 6 years ago

@evocateur I also noticed that the --conventional-commits flag seems to work properly in independent mode.

though admittedly not from lerna-changelog directly

Not sure how to interpret this - was it meant as a hint to look into the code there and potentially reuse some of its logic to gather the relevant info or did you have some specific solution based on that in mind?

Update lerna version --conventional-commits seems to achieve the separate changelogs in 3.x, which obsoletes my question.

zero-t4 commented 4 years ago

lerna publish --conventional-commits supports per-project changelogs in --independent mode, though admittedly not from lerna-changelog directly.

Why doesn't this flag mentioned in docs?

kylemh commented 4 years ago

I'd love to integrate some sort of fix for independent mode. I quite like the idea of label-driven changelogs vs. a commit message standard.

Where would this change need to be made?

I can clearly see where I can help infer the package names, but once I have them, I'm not sure how to run the changelog generator against each package. A backward compatible change would be to change repo to packages as an array of strings. A non-independent monorepo would simply be an array of one item.

Do we still want one root-level CHANGELOG.md or should it be per package?

If it's root-level, should there be any new formatting?

kylemh commented 4 years ago

@Turbo87 any comments on the above? Really interested in getting this working. I want the PR labels stuff so bad - think it's so much better than relying on commit linting.

Turbo87 commented 4 years ago

unfortunately I don't use lerna or yarn workspaces so it's hard for me to comment on this 🙁