search

lerouxrgd / rsgen-avro

Command line and library for generating Rust types from Avro schemas
MIT License
36 stars 29 forks source link

Fixes #25 - Migrate to Apache Avro Rust SDK #26

Closed martin-g closed 2 years ago

martin-g commented 2 years ago

Flavray's avro_rs has been donated to Apache Avro project some months ago.

There are many improvements since then. It seems the problem for issue #25 was also fixed.

martin-g commented 2 years ago

More info at https://github.com/flavray/avro-rs/pull/99#issuecomment-1017195592

lerouxrgd commented 2 years ago

I converted the PR to draft in the meantime.

lerouxrgd commented 2 years ago

I think there are also some templated types to replace, like avro_rs::Duration or avro_rs::Decimal

martin-g commented 2 years ago

think there are also some templated types to replace, like avro_rs::Duration or avro_rs::Decimal

Done!

gen::tests::cross_deps is broken at the moment! I'll try to debug it!

martin-g commented 2 years ago

The test is fixed!

martin-g commented 2 years ago

No, he didn't. See the vote thread. Short answer: I will do it at Wednesday.

On Mon, Aug 1, 2022, 15:02 Lionel Untereiner @.***> wrote:

@.**** commented on this pull request.

In Cargo.toml https://github.com/lerouxrgd/rsgen-avro/pull/26#discussion_r934450123:

@@ -10,7 +10,7 @@ license = "MIT" readme = "README.md"

[dependencies] -avro-rs = "0.13" +apache-avro = {path="/home/martin/git/apache/avro/lang/rust/avro"}

Hey! Did the release manager forget the rust package on crates.io ? I see the releases in javascript/python/etc. but not the rust one.

— Reply to this email directly, view it on GitHub https://github.com/lerouxrgd/rsgen-avro/pull/26#discussion_r934450123, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYUQU7SMTEFA6N2SUTZUTVW64EJANCNFSM5TNA3J4Q . You are receiving this because you were mentioned.Message ID: @.***>

untereiner commented 2 years ago

my apologies, thank you for the answer

martin-g commented 2 years ago

https://crates.io/crates/apache-avro 0.14.0 has been released! I will update this PR soon!

lerouxrgd commented 2 years ago

Thanks a lot for this PR, it looks all good ! Could you just squash the commits before I merge it ? (Or I can squash them from GitHub, as you prefer)

martin-g commented 2 years ago

Please squash them with Github UI! Thanks!