Use serde_bytes crate for serializing Schema::Bytes

lerouxrgd / rsgen-avro

Command line and library for generating Rust types from Avro schemas

MIT License

36 stars 29 forks source link

Use serde_bytes crate for serializing Schema::Bytes #36

Closed martin-g closed 2 years ago

martin-g commented 2 years ago

Reported at Apache Avro user@ mailing list: https://lists.apache.org/thread/cmkc6b7g5pqh63odtrj5vg502w7o4n4h

lerouxrgd commented 2 years ago

Thanks for the PR !

martin-g commented 2 years ago

Once https://github.com/serde-rs/bytes/issues/26 is implemented we can do the same for Schema::Fixed too

martin-g commented 2 years ago

Or maybe use https://github.com/jonasbb/serde_with instead ?!

rajivr commented 2 years ago

Or maybe use https://github.com/jonasbb/serde_with instead ?!

I took a look at serde_with before replying to your e-mail. Its just my personal opinion, but I felt the code base of serde-rs/bytes is simpler. It is also maintained within the Serde project, by the same maintainers. Hence, I went with it.