search

lesaff / serverpilot-letsencrypt

(NO LONGER MAINTAINED) | Bash script to generate and install Let's Encrypt certificate for your websites on your ServerPilot account (Free or Paid Plan)
MIT License
346 stars 84 forks source link

Brotli compression not enabled #37

Closed Olsserik closed 7 years ago

Olsserik commented 7 years ago

Hi, When using this (awesome) script it seems that it not enables Brotli compression. When using Serverpilot paid function they enable Brotli with HTTP/2.

Any clues on how to enable Brotli with this script?

caroseuk commented 7 years ago

As soon as SSL is enabled on the server brotli compression should be automatic.

I've just checked and assets from my site are showing with encoding of "br"

If your using Chrome, open the inspector and reload a page on your server. Select a style sheet (as an example) and it should say in the response headers:

content encoding: br

On 12 May 2017, at 08:33, Olsserik notifications@github.com wrote:

Hi, When using this (awesome) script it seems that it not enables Brotli compression. When using Serverpilot paid function they enable Brotli with HTTP/2.

Any clues on how to enable Brotli with this script?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Olsserik commented 7 years ago

Hi, Yes, that's exactly what I did, using chrome. I get h2 - https - gzip - nginx

Have I done anything wrong in setup?

Olsserik commented 7 years ago

Wrong button...

caroseuk commented 7 years ago

Whats your domain?

Olsserik commented 7 years ago

It's a non-public (for now), can I send you PM?

caroseuk commented 7 years ago

sure send it to [email redacted]

Olsserik commented 7 years ago

Sent!

Olsserik commented 7 years ago

@caroseuk fixed the issue. I had AddOutputFilterByType DEFLATE in .htaccess. When gone it Brotlis like never before.