search

lesaff / serverpilot-letsencrypt

(NO LONGER MAINTAINED) | Bash script to generate and install Let's Encrypt certificate for your websites on your ServerPilot account (Free or Paid Plan)
MIT License
346 stars 84 forks source link

Support for Let's Encrypt ACMEv2 and Wildcard certificate #65

Closed harryqt closed 6 years ago

harryqt commented 6 years ago

Discussion - https://community.letsencrypt.org/t/acmev2-and-wildcard-launch-delay/53654

The API will be release tomorrow (February 27) publicly. I think @lesaff will have to revamp the script to make it support, right?

since, we don't have to generate SSL for every subdomain now, only the for root domain.

caroseuk commented 6 years ago

I dont think so, if that was the case, anyone who uses LetsEncrypt (Millions of users) would need to change scripts/update systems.

TLS-SNI01 has been disabled due to the security flaw, and it's fallback is the HTTP-01 method. so existing certs should still renew without issue.

There will eventually be an update to the Cerbot/LetsEncrypt upstream packages which will more than likely have an added flag or similar for the wildcard functionality.

In short, I don't think the script will need amending immediately, though would be cool, once the packages are updated :)

harryqt commented 6 years ago

Yeah, that’s exactly I meant. The script will need a update so we will have to generate certificate for only root domain, but the certificate will work on any subdomain. That’s exactly what I want. I hate to generate certificate for each subdomain.

lesaff commented 6 years ago

Yes, this will require a rewrite of the bash script. I am also working on a new Node-based script to replace the old one, complete with web interface. Stay tuned.

caroseuk commented 6 years ago

@lesaff have you got a repo I can play with? ;)

lesaff commented 6 years ago

Not yet. I will put it on a new branch when it's ready for testing. I will definitely need your help.

harryqt commented 6 years ago

@lesaff The new API seems to have released. Any updates?

hbakhtiyor commented 5 years ago

@lesaff any updates? only one branch in the repo