lesbird / MAME4apple-037b5

MAME 0.37B5 for iOS devices. 64-bit, rebuilt from the original 0.37B5 source code, SpriteKit renderer.
84 stars 25 forks source link

Ability to just show the ROMs loaded (not the entire list) #7

Closed yogi1967 closed 8 years ago

yogi1967 commented 8 years ago

Perhaps not quite a bug, but the app is almost unusable when you have to slowly scroll through the 2000 potential game titles to find the exact one you have loaded and want to play. Impossible if you are not quite sure which one in a set it is. Please can there be a simple filter to only show on the game select menu the game roms actually loaded? Thanks

lesbird commented 8 years ago

Hi, so you'd like the app to cross reference all the game titles with the roms you copied to your device? Yes, that should be possible. I will try to get that in by this weekend. Thanks for the suggestion.

yogi1967 commented 8 years ago

Hi, yes. So if I've only loaded 5 roms , I only want to see those 5 listed. Thanks.

lesbird commented 8 years ago

Just updated the project to show only games with valid ROMs installed.

iostriz commented 8 years ago

It does not work for me - (I'm using iPad for now). I have found that the problem is at line 470 in file GameScene.m. Currently, it looks like:

NSString *path = [NSString stringWithUTF8String:getROMpath()];
[path stringByAppendingPathComponent:[NSString stringWithUTF8String:gameDriverList[i].gameDriver->name]];

The problem is that stringByAppendingPathComponent does not modify path, it returns a new string (NSString is immutable). It should be something like:

NSString *path = [NSString stringWithUTF8String:getROMpath()];
path = [path stringByAppendingPathComponent:[NSString stringWithUTF8String:gameDriverList[i].gameDriver->name]];
path = [path stringByAppendingPathExtension:@"zip"];

Also, I have added "zip" extension, because I'm using zip ROMs, I don't know the variety of formats they can come...

lesbird commented 8 years ago

Oh wow, I wonder how that happened. Haha. Obviously I was pretty distracted when I wrote that because you're right, no way that would work.

orff commented 8 years ago

Latest version shows a filtered list for me ( iOS version ).

iostriz commented 8 years ago

You can close it now, I guess...