search

lesfurets / zeno-pixel

Pixel monitoring tool
GNU Affero General Public License v3.0
41 stars 6 forks source link

Support for PhantomJS 2.0 #4

Closed dbaeli closed 8 years ago

dbaeli commented 9 years ago

We are using flexbox css features which are only supported by phantomjs 2.0 (https://github.com/ariya/phantomjs/issues/13264)

Is there any risk/impact to upgrade to phantomJS 2.0 ?

CaptainMat commented 9 years ago

As explained here: http://phantomjs.org/download.html, linux binaries are not available for phantom2.0 so the js wrapper too: https://github.com/Medium/phantomjs/issues/288

but I use it on Mac and there is no problem. If you build your own binary, you can overide phantomjs path in engine.js

dbaeli commented 9 years ago

Thanks, I'm trying using https://github.com/bprodoehl/phantomjs/releases I'll keep you informed

dbaeli commented 9 years ago

Can the phantomjs version displayed at start not be a string from packaging but a run of 'phantomjs --version' ? It's hard to get rid of the use of phantomjs modules