search

lesgourg / class_public

Public repository of the Cosmic Linear Anisotropy Solving System (master for the most recent version of the standard code; GW_CLASS to include Cosmic Gravitational Wave Background anisotropies; classnet branch for acceleration with neutral networks; ExoCLASS branch for exotic energy injection; class_matter branch for FFTlog)
230 stars 285 forks source link

classy version number doesn't get updated when downgrading from 2.8 to 2.7 #299

Open lukashergt opened 4 years ago

lukashergt commented 4 years ago

After upgrading to CLASS v2.8.1 and then downgrading to v2.7.2 the classy version number does not follow the downgrade, i.e. the downgrade works fine it's just the version number that still displays 2.8.1, e.g. when calling pip list.

I suspect this comes from commit 06ae2ef where the version handling seems to have been changed to manual.

Side note: I had to downgrade because the memory leak described in JesusTorrado/CobayaSampler/cobaya#34 got actually worse with the 2.8 update. I'm not sure whether I should raise a separate issue for this also here on the CLASS repo. If you'd like me to do that, let me know.

lesgourg commented 4 years ago

Dear Lukas, Tomorrow (3.12.2020) there will be a new minor release: v2.8.2. I expect that this will fix both this version number issue and the memory leaks that you found in nested sampling runs with wide priors. If it doesn't, don't hesitate to write again. Cheers, Julien

lesgourg commented 4 years ago

Dear Lukas, do you confirm that with v2.8.2 you have no longer problems with memory leaks and with version numbers? If you do, I will close this issue. Julien

lukashergt commented 4 years ago

Hi Julien, version number downgrading from 2.8 to 2.7 still doesn't work. I think this would require a similar change as done in commit 54ed17c for the 2.7 branch. I'd be happy to try and draft up a PR for this, if that would be useful.