search

leshill / handlebars_assets

Use handlebars.js templates with the Rails asset pipeline.
MIT License
649 stars 159 forks source link

Breaking changes with assets:precompile in version 0.17 #105

Closed tagliala closed 10 years ago

tagliala commented 10 years ago

Hi, I'm getting the following error with assets precompile:

Compiled application.js  (1760ms)  (pid 45813)
rake aborted!
ExecJS::ProgramError: Unexpected token: operator (<) (line: 15388, col: 0, pos: 454662)

Error
    at new JS_Parse_Error (/private/var/folders/yb/dp9312b55mq4clqdwlx7k8s00000gn/T/execjs20140627-45813-1hwqzwi.js:2357:10754)
    at js_error (/private/var/folders/yb/dp9312b55mq4clqdwlx7k8s00000gn/T/execjs20140627-45813-1hwqzwi.js:2357:10973)
    at croak (/private/var/folders/yb/dp9312b55mq4clqdwlx7k8s00000gn/T/execjs20140627-45813-1hwqzwi.js:2357:19198)
    at token_error (/private/var/folders/yb/dp9312b55mq4clqdwlx7k8s00000gn/T/execjs20140627-45813-1hwqzwi.js:2357:19335)
    at unexpected (/private/var/folders/yb/dp9312b55mq4clqdwlx7k8s00000gn/T/execjs20140627-45813-1hwqzwi.js:2357:19423)
    at expr_atom (/private/var/folders/yb/dp9312b55mq4clqdwlx7k8s00000gn/T/execjs20140627-45813-1hwqzwi.js:2357:27615)
    at maybe_unary (/private/var/folders/yb/dp9312b55mq4clqdwlx7k8s00000gn/T/execjs20140627-45813-1hwqzwi.js:2357:30108)
    at expr_ops (/private/var/folders/yb/dp9312b55mq4clqdwlx7k8s00000gn/T/execjs20140627-45813-1hwqzwi.js:2357:30866)
    at maybe_conditional (/private/var/folders/yb/dp9312b55mq4clqdwlx7k8s00000gn/T/execjs20140627-45813-1hwqzwi.js:2357:30958)
    at maybe_assign (/private/var/folders/yb/dp9312b55mq4clqdwlx7k8s00000gn/T/execjs20140627-45813-1hwqzwi.js:2357:31401)
    at expression (/private/var/folders/yb/dp9312b55mq4clqdwlx7k8s00000gn/T/execjs20140627-45813-1hwqzwi.js:2357:31714)
    at simple_statement (/private/var/folders/yb/dp9312b55mq4clqdwlx7k8s00000gn/T/execjs20140627-45813-1hwqzwi.js:2357:22652)
    at /private/var/folders/yb/dp9312b55mq4clqdwlx7k8s00000gn/T/execjs20140627-45813-1hwqzwi.js:2357:20580
  (in /Users/user/dev/icare/app/assets/javascripts/application.js.coffee)/Users/user/.rvm/gems/ruby-2.1.2/gems/execjs-2.1.0/lib/execjs/external_runtime.rb:67:in `extract_result'
/Users/user/.rvm/gems/ruby-2.1.2/gems/execjs-2.1.0/lib/execjs/external_runtime.rb:27:in `block in exec'
/Users/user/.rvm/gems/ruby-2.1.2/gems/execjs-2.1.0/lib/execjs/external_runtime.rb:40:in `compile_to_tempfile'
/Users/user/.rvm/gems/ruby-2.1.2/gems/execjs-2.1.0/lib/execjs/external_runtime.rb:26:in `exec'
/Users/user/.rvm/gems/ruby-2.1.2/gems/uglifier-2.5.0/lib/uglifier.rb:186:in `really_compile'
/Users/user/.rvm/gems/ruby-2.1.2/gems/uglifier-2.5.0/lib/uglifier.rb:110:in `compile'
/Users/user/.rvm/gems/ruby-2.1.2/gems/actionpack-3.2.18/lib/sprockets/compressors.rb:74:in `compress'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/processing.rb:265:in `block in js_compressor='
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/processor.rb:29:in `call'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/processor.rb:29:in `evaluate'
/Users/user/.rvm/gems/ruby-2.1.2/gems/tilt-1.4.1/lib/tilt/template.rb:103:in `render'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/context.rb:193:in `block in evaluate'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/context.rb:190:in `each'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/context.rb:190:in `evaluate'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/bundled_asset.rb:26:in `initialize'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/base.rb:252:in `new'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/base.rb:252:in `build_asset'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/index.rb:93:in `block in build_asset'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/caching.rb:19:in `cache_asset'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/index.rb:92:in `build_asset'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/base.rb:169:in `find_asset'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/index.rb:60:in `find_asset'
/Users/user/.rvm/gems/ruby-2.1.2/gems/actionpack-3.2.18/lib/sprockets/static_compiler.rb:19:in `block in compile'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/base.rb:219:in `block in each_logical_path'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/base.rb:206:in `block (2 levels) in each_file'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/base.rb:196:in `each'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/base.rb:196:in `each_entry'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/base.rb:204:in `block in each_file'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/base.rb:203:in `each'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/base.rb:203:in `each_file'
/Users/user/.rvm/gems/ruby-2.1.2/gems/sprockets-2.2.2/lib/sprockets/base.rb:217:in `each_logical_path'
/Users/user/.rvm/gems/ruby-2.1.2/gems/actionpack-3.2.18/lib/sprockets/static_compiler.rb:18:in `compile'
/Users/user/.rvm/gems/ruby-2.1.2/gems/actionpack-3.2.18/lib/sprockets/assets.rake:56:in `internal_precompile'
/Users/user/.rvm/gems/ruby-2.1.2/gems/actionpack-3.2.18/lib/sprockets/assets.rake:70:in `block (3 levels) in <top (required)>'
/Users/user/.rvm/gems/ruby-2.1.2/gems/actionpack-3.2.18/lib/sprockets/assets.rake:60:in `block (3 levels) in <top (required)>'
Tasks: TOP => assets:precompile:primary
(See full trace by running task with --trace)
rake aborted!
Command failed with status (1): [/Users/user/.rvm/rubies/ruby-2.1.2/bin/...]
/Users/user/.rvm/gems/ruby-2.1.2/gems/actionpack-3.2.18/lib/sprockets/assets.rake:12:in `ruby_rake_task'
/Users/user/.rvm/gems/ruby-2.1.2/gems/actionpack-3.2.18/lib/sprockets/assets.rake:21:in `invoke_or_reboot_rake_task'
/Users/user/.rvm/gems/ruby-2.1.2/gems/actionpack-3.2.18/lib/sprockets/assets.rake:29:in `block (2 levels) in <top (required)>'
/Users/user/.rvm/gems/ruby-2.1.2/bin/ruby_executable_hooks:15:in `eval'
/Users/user/.rvm/gems/ruby-2.1.2/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => assets:precompile
(See full trace by running task with --trace)

After downgrading to 0.16, everything is fine

Compiled application.js  (2022ms)  (pid 46642)

Here it is my source code: https://github.com/diowa/icare/tree/hotfix/0.13.2

Let me know if you need further information

AlexRiedler commented 10 years ago

checked out your exact source, and I could not reproduce:

Compiled jquery.js  (5ms)  (pid 42615)
Compiled jquery_ujs.js  (0ms)  (pid 42615)
Compiled jquery.turbolinks.js  (0ms)  (pid 42615)
Compiled turbolinks.js  (210ms)  (pid 42615)
Compiled jquery.ba-throttle-debounce.js  (0ms)  (pid 42615)
Compiled rails.validations.js  (2ms)  (pid 42615)
Compiled rails.validations.turbolinks.js  (0ms)  (pid 42615)
Compiled twbs/bootstrap/transition.js  (0ms)  (pid 42615)
Compiled twbs/bootstrap/alert.js  (0ms)  (pid 42615)
Compiled twbs/bootstrap/button.js  (0ms)  (pid 42615)
Compiled twbs/bootstrap/collapse.js  (0ms)  (pid 42615)
Compiled twbs/bootstrap/dropdown.js  (0ms)  (pid 42615)
Compiled twbs/bootstrap/modal.js  (0ms)  (pid 42615)
Compiled twbs/bootstrap/tooltip.js  (0ms)  (pid 42615)
Compiled twbs/bootstrap/popover.js  (0ms)  (pid 42615)
Compiled handlebars.runtime.js  (0ms)  (pid 42615)
Compiled i18n.js  (0ms)  (pid 42615)
Compiled i18n/translations.js  (0ms)  (pid 42615)
Compiled bootstrap.js  (114ms)  (pid 42615)
Compiled conversations.js  (112ms)  (pid 42615)
Compiled fbjssdk.js  (132ms)  (pid 42615)
Compiled forms.js  (137ms)  (pid 42615)
Compiled handlebars-helpers.js  (116ms)  (pid 42615)
Compiled maps--main.js  (166ms)  (pid 42615)
Compiled maps-new.js  (184ms)  (pid 42615)
Compiled maps-search.js  (167ms)  (pid 42615)
Compiled navbar.js  (142ms)  (pid 42615)
Compiled pages.js  (117ms)  (pid 42615)
Compiled templates/gmaps_popup.js  (80ms)  (pid 42615)
Compiled templates/itineraries/thumbnail.js  (78ms)  (pid 42615)
Compiled templates/notifications/base.js  (84ms)  (pid 42615)
Compiled templates/notifications/messages.js  (72ms)  (pid 42615)
Compiled turbolinks-spinner.js  (119ms)  (pid 42615)
Compiled application.js  (2583ms)  (pid 42615)
Compiled twbs.css  (1701ms)  (pid 42615)
Compiled conversation.css  (323ms)  (pid 42615)
Compiled dashboard.css  (307ms)  (pid 42615)
Compiled footer.css  (361ms)  (pid 42615)
Compiled forms.css  (316ms)  (pid 42615)
Compiled home.css  (441ms)  (pid 42615)
Compiled icare.css  (423ms)  (pid 42615)
Compiled itineraries.css  (340ms)  (pid 42615)
Compiled maps.css  (335ms)  (pid 42615)
Compiled navbar.css  (357ms)  (pid 42615)
Compiled notifications.css  (355ms)  (pid 42615)
Compiled pages.css  (314ms)  (pid 42615)
Compiled references.css  (318ms)  (pid 42615)
Compiled ribbon.css  (346ms)  (pid 42615)
Compiled tags.css  (370ms)  (pid 42615)
Compiled turbolinks-spinner.css  (335ms)  (pid 42615)
Compiled twbs-variables.css  (306ms)  (pid 42615)
Compiled users.css  (336ms)  (pid 42615)
Compiled application.css  (7960ms)  (pid 42615)
Compiled respond.js  (0ms)  (pid 42615)
Compiled jquery.js  (4ms)  (pid 42615)
Compiled jquery_ujs.js  (0ms)  (pid 42615)
Compiled jquery.turbolinks.js  (0ms)  (pid 42615)
Compiled turbolinks.js  (182ms)  (pid 42615)
Compiled jquery.ba-throttle-debounce.js  (0ms)  (pid 42615)
Compiled rails.validations.js  (0ms)  (pid 42615)
Compiled rails.validations.turbolinks.js  (0ms)  (pid 42615)
Compiled twbs/bootstrap/transition.js  (0ms)  (pid 42615)
Compiled twbs/bootstrap/alert.js  (0ms)  (pid 42615)
Compiled twbs/bootstrap/button.js  (0ms)  (pid 42615)
Compiled twbs/bootstrap/collapse.js  (0ms)  (pid 42615)
Compiled twbs/bootstrap/dropdown.js  (0ms)  (pid 42615)
Compiled twbs/bootstrap/modal.js  (0ms)  (pid 42615)
Compiled twbs/bootstrap/tooltip.js  (0ms)  (pid 42615)
Compiled twbs/bootstrap/popover.js  (0ms)  (pid 42615)
Compiled handlebars.runtime.js  (0ms)  (pid 42615)
Compiled i18n.js  (0ms)  (pid 42615)
Compiled i18n/translations.js  (0ms)  (pid 42615)
Compiled bootstrap.js  (111ms)  (pid 42615)
Compiled conversations.js  (113ms)  (pid 42615)
Compiled fbjssdk.js  (134ms)  (pid 42615)
Compiled forms.js  (136ms)  (pid 42615)
Compiled handlebars-helpers.js  (121ms)  (pid 42615)
Compiled maps--main.js  (168ms)  (pid 42615)
Compiled maps-new.js  (186ms)  (pid 42615)
Compiled maps-search.js  (172ms)  (pid 42615)
Compiled navbar.js  (141ms)  (pid 42615)
Compiled pages.js  (115ms)  (pid 42615)
Compiled templates/gmaps_popup.js  (74ms)  (pid 42615)
Compiled templates/itineraries/thumbnail.js  (80ms)  (pid 42615)
Compiled templates/notifications/base.js  (85ms)  (pid 42615)
Compiled templates/notifications/messages.js  (69ms)  (pid 42615)
Compiled turbolinks-spinner.js  (118ms)  (pid 42615)
Compiled application.js  (2264ms)  (pid 42615)
Compiled twbs.css  (2000ms)  (pid 42615)
Compiled conversation.css  (320ms)  (pid 42615)
Compiled dashboard.css  (329ms)  (pid 42615)
Compiled footer.css  (356ms)  (pid 42615)
Compiled forms.css  (315ms)  (pid 42615)
Compiled home.css  (505ms)  (pid 42615)
Compiled icare.css  (388ms)  (pid 42615)
Compiled itineraries.css  (342ms)  (pid 42615)
Compiled maps.css  (333ms)  (pid 42615)
Compiled navbar.css  (351ms)  (pid 42615)
Compiled notifications.css  (332ms)  (pid 42615)
Compiled pages.css  (318ms)  (pid 42615)
Compiled references.css  (337ms)  (pid 42615)
Compiled ribbon.css  (365ms)  (pid 42615)
Compiled tags.css  (367ms)  (pid 42615)
Compiled turbolinks-spinner.css  (326ms)  (pid 42615)
Compiled twbs-variables.css  (295ms)  (pid 42615)
Compiled users.css  (340ms)  (pid 42615)
Compiled application.css  (8274ms)  (pid 42615)
Compiled respond.js  (0ms)  (pid 42615)

I am confused why it is not working for you...

AlexRiedler commented 10 years ago

Ignore my previous comment, I replicated! @tagliala it has been fixed in 0.17.1 (just released) all my testing environments initialize the app on precompile is why it was not caught (needed the engine to be in all groups).

@tagliala verify though before I close this issue.

tagliala commented 10 years ago

@AlexRiedler it works now, thanks!

AlexRiedler commented 10 years ago

@tagliala no problem, just doing my job :smile: :+1:

simzen85 commented 9 years ago

hi @AlexRiedler I seem to have this issue again with master branch. My .jst.hbs file seems to be included incorrectly in the application JS http://take.ms/HnXcM

Can you take a look at this ? Thanks.

AlexRiedler commented 9 years ago

@simzen85 I will get around to this tonight hopefully; was sick in bed yesterday, and just moved into a new apartment on the weekend.

That is super weird though; it looks uncompiled? is that the case? (not sure if it is actually this gem compiling it).