search

leshill / handlebars_assets

Use handlebars.js templates with the Rails asset pipeline.
MIT License
649 stars 159 forks source link

reset config and handlebars on tests setup instead of teardown #138

Closed sathieu closed 2 years ago

sathieu commented 8 years ago

This allows overriding defaults in test/test_helper.rb

sathieu commented 8 years ago

We need this in the Debian package, because the compiler path is changed.

AlexRiedler commented 8 years ago

@sathieu I am confused, your PR only modifies tests.... and ... Debian Package???

sathieu commented 8 years ago

The other part of the patch is Debian-specific.

See http://anonscm.debian.org/cgit/pkg-ruby-extras/ruby-handlebars-assets.git/tree/debian/patches/0002-Fix-slimbars-test.patch#n29

AlexRiedler commented 7 years ago

@sathieu I know its been a while; I am just wondering what this package is doing in pkg-ruby-extras? Closing cause test code should be run in the gem's environment.

sathieu commented 7 years ago

FYI, we'll need to keep the patch in Debian forever then.

AlexRiedler commented 7 years ago

@sathieu you can at least point me at a bug report ? or something of that nature. I am unsure what this is trying to solve exactly by doing this.

Other question; who would have sponsored this going into a debian package? seems like a weird offering ... this is an extenstion for asset compilation in rails is why I ask.

sathieu commented 7 years ago

Yes. See https://bugs.debian.org/795664.

Because some people (including me) prefer using .deb over gems (they are frozen, while having security support).

sathieu commented 2 years ago

Closing this old PR (I don't care anymore).