search

leshill / handlebars_assets

Use handlebars.js templates with the Rails asset pipeline.
MIT License
649 stars 159 forks source link

Sprockets method `register_engine` is deprecated. #154

Closed jwg2s closed 7 years ago

jwg2s commented 7 years ago 
DEPRECATION WARNING: Sprockets method `register_engine` is deprecated.
Please register a mime type using `register_mime_type` then
use `register_compressor` or `register_transformer`.
https://github.com/rails/sprockets/blob/master/guides/extending_sprockets.md#supporting-all-versions-of-sprockets-in-processors
 (called from block in register_extensions at /app/vendor/bundle/ruby/2.3.0/gems/handlebars_assets-0.17.2/lib/handlebars_assets.rb:20)

Any plans to update this?

AlexRiedler commented 7 years ago

Was not aware of the change in sprockets. Will get around to it when I can; also accepting PRs

On Tue, Aug 16, 2016, 15:37 John Gerhardt notifications@github.com wrote:

DEPRECATION WARNING: Sprockets method register_engine is deprecated. Please register a mime type using register_mime_type then use register_compressor or register_transformer.https://github.com/rails/sprockets/blob/master/guides/extending_sprockets.md#supporting-all-versions-of-sprockets-in-processors (called from block in register_extensions at /app/vendor/bundle/ruby/2.3.0/gems/handlebars_assets-0.17.2/lib/handlebars_assets.rb:20)

Any plans to update this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/leshill/handlebars_assets/issues/154, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVQdyOhPy9ipRCKCV3IHIhYrrjFczN8ks5qghGMgaJpZM4JlxYU .

jwg2s commented 7 years ago

@AlexRiedler I think it's actually fixed in the newer version of handlebars_assets, we were locked to 0.17.x. Nothing to do here!