leshill / handlebars_assets

Use handlebars.js templates with the Rails asset pipeline.
MIT License
648 stars 159 forks source link

update to Handlebars 1.0.0-rc.4 #61

Closed turadg closed 11 years ago

turadg commented 11 years ago

v1.0.11 / 1.0.0-rc4 - May 13 2013

Commits

leshill commented 11 years ago

Hi @turadg,

Please fix the two failing specs in your branch and we can merge this in!

turadg commented 11 years ago

As requested.

leshill commented 11 years ago

Hi @turadg,

Thanks! Pushed out v0.12.1. I am a little concerned about the patch change – that should not have been required, I will look into it.

turadg commented 11 years ago

Thanks for looking into it. I was a little apprehensive myself, but all the tests passed. ;)

On Tue, May 21, 2013 at 3:08 PM, Les Hill notifications@github.com wrote:

Hi @turadg https://github.com/turadg,

Thanks! Pushed out v0.12.1. I am a little concerned about the patch change – that should not have been required, I will look into it.

— Reply to this email directly or view it on GitHubhttps://github.com/leshill/handlebars_assets/pull/61#issuecomment-18231687 .

runemadsen commented 11 years ago

For another time, shouldn't this at least be a 0.13 change for people with ~> in their gemfiles? I started seeing problems like the following (although it's very possible that it's my own fault, as I'm moving stuff around. But it just made me think).

Template was precompiled with an older version of Handlebars than the current runtime. Please update your precompiler to a newer version (>= 1.0.0-rc.4) or downgrade your runtime to an older version (== 1.0.0-rc.3).
runemadsen commented 11 years ago

Had to clean /tmp to make this work.

leshill commented 11 years ago

Hi @runemadsen,

Yes, that is a good idea for the future. Unfortunately it would not affect devs (possibly a majority?) with no version specified.

To recompile everything, run rake assets:clean.