search

leshow / rotary-encoder-hal

A simple platform agnostic rotary encoder library
MIT License
28 stars 15 forks source link

table-decoder vs default decoder have different steps #15

Open sjoerdsimons opened 2 years ago

sjoerdsimons commented 2 years ago

The table decoder does one step when the rotary encoder does one full idle -> idle transition; Which matches at least the tactile steps on my rotary encoder. The "default" decoder does a step on each state transition instead; Which means it ends up doing 4 steps for one tactile step instead.

Unsure if this was intential? at the least seems surprising nonetheless.

leshow commented 2 years ago

The table decoder was added in #3 by another contributor, and it's been so long since I looked at any of this I can't say what I was thinking at the time. I remember that it worked on a little test circuit I had, but nothing beyond that.

ahmedcharles commented 1 year ago

I have a plan to resolve this, just working through the PR's one at a time.