fix(image): handle relative url, catch axios 404 error

lesjoursfr / html-to-epub

Generate EPUB books from HTML with simple API in Node.js.

MIT License

39 stars 16 forks source link

fix(image): handle relative url, catch axios 404 error #97

Closed volodymyrburdeinyi closed 1 year ago

volodymyrburdeinyi commented 1 year ago

This pr tries to fix errors on images:

image src has only // without schema defined, it is still valid markup
image is not found 404, axios raised error

those two errors prevented book generation to finish sucessfully

volodymyrburdeinyi commented 1 year ago

@e-adrien can you please review this pr?

e-adrien commented 1 year ago

Thank you for this PR. If you can just add checks on the verbose option to avoid calling console.error when the option is false I'll be happy to merge it.

like: https://github.com/lesjoursfr/html-to-epub/blob/7402c37f067e7ac6168973a9a08eb98214b20ee4/src/index.ts#L713-L715

volodymyrburdeinyi commented 1 year ago

Thank you for this PR. If you can just add checks on the verbose option to avoid calling console.error when the option is false I'll be happy to merge it.

like:

https://github.com/lesjoursfr/html-to-epub/blob/7402c37f067e7ac6168973a9a08eb98214b20ee4/src/index.ts#L713-L715

@e-adrien all done, thanks for reviewing

e-adrien commented 1 year ago

The QC error is not related to your changes, I will fix it later. Thank you for this PR, I'll publish a new version with this fix in the coming hours.