search

lesnitsky / flutter_localstorage

📦 LocalStorage for Flutter
MIT License
301 stars 60 forks source link

fix: update path_provider_fde to url_launcher_fde #34

Closed CoreyCole closed 4 years ago

CoreyCole commented 4 years ago

was getting an error

Could not find a file named "plugins/flutter_plugins/path_provider_fde/pubspec.yaml"

path_provider_fde does not exist anymore, see here

lesnitsky commented 4 years ago

That's not a correct fix. url_launcher has nothing to do with localstorage package. path_provider was merged into main repo and it should just work on desktop w/o any additional steps. Desktop support support section should be just dropped from readme. Would you be interested doing this?

CoreyCole commented 4 years ago

Ah makes sense, sorry I misunderstood.. the error went away but didn't get a chance to test it.

I'll edit the PR to remove the desktop support section.

lesnitsky commented 4 years ago

thanks

On Thu, Dec 26, 2019, 2:58 AM Corey Cole notifications@github.com wrote:

Ah makes sense, sorry I misunderstood.. the error went away but didn't get a chance to test it.

I'll edit the PR to remove the desktop support section.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lesnitsky/flutter_localstorage/pull/34?email_source=notifications&email_token=ABPYUNRQVQNYDYOWJ3KHZULQ2PXRLA5CNFSM4J7DQJYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHUVD5Q#issuecomment-568938998, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPYUNR6OYDRNRBOGD7PLULQ2PXRLANCNFSM4J7DQJYA .