search

lespalt / iRon

MIT License
135 stars 20 forks source link

Overlay pos issue #17

Open Martin-Alba opened 1 year ago

Martin-Alba commented 1 year ago

Howdy, I have a bug where I can't move my overlays to position them. I tried several ways and I couldn't do it. The only solution was to open the JSON in my vscode to modify the position with window_pos_x & window_pos_y

If you have no problem, when I have some free time I can collaborate :]

frmjar commented 1 year ago

Hi @Martin-Alba, i did a fork a few days ago. I'm working in the overlays adding new features and fixeds. You are welcome to help me if u want it :)

byBlurr commented 1 year ago

@frmjar Will you be making a pr back to this repo?

frmjar commented 1 year ago

@byBlurr The truth is that I had not thought about it, but if it is of help I can do. I have added a lot of things to the overlays. But there are still many more to be done. there are also many improvements and corrections to be made. The relative times in the multiclass races are not working properly, for example... I would like to add the loss or gain of irating in real time (I have a quite complex formula for a possible implementation). There are many things to do.

byBlurr commented 1 year ago

@frmjar I am down to help out with the smaller stuff, I dont have my sim pc with me so can't test bigger stuff atm. I have an active pr, if you want to test it.

Not sure how active @lespalt is, to accept pull requests?

frmjar commented 1 year ago

@byBlurr I have seen your PR. If I play this afternoon I will try it. As far as I've been able to see, this repo looks like it hasn't had much support for quite some time.

lespalt commented 1 year ago

I don't have time to actively develop on this at the moment, but am happy to look at PRs.

byBlurr commented 1 year ago

@lespalt @frmjar Could we create a Discord group/server or something for iRon contributors? Save us spamming the comments on issues/pr unnecessarily

byBlurr commented 1 year ago

I would like to add the loss or gain of irating in real time (I have a quite complex formula for a possible implementation)

@frmjar issue #4 might be of use to you.

frmjar commented 1 year ago

I would like to add the loss or gain of irating in real time (I have a quite complex formula for a possible implementation)

@frmjar issue #4 might be of use to you.

The formula that is in that excel is the one that I have

frmjar commented 1 year ago

@lespalt @frmjar Could we create a Discord group/server or something for iRon contributors? Save us spamming the comments on issues/pr unnecessarily

As you wish but currently in my fork I have made too many changes to make a PR in this repo....

image

byBlurr commented 1 year ago

Are there any conflicts? Or is it that some of the changes are preference based?

frmjar commented 1 year ago

Both

byBlurr commented 1 year ago

My discord user is imrblurr. If @lespalt or @frmjar want to make a group chat, we can look through and see if we can get it merged

frmjar commented 1 year ago

I have some changes that work very well and are very useful to me personally. Then I have other very personal changes that may not be very useful for some people. All the modifications that I have been making have been done thinking about my needs.