search

lespalt / iRon

MIT License
135 stars 20 forks source link

#18 Limiter dashboard feedback Implementation, #14 debug fix #21

Open byBlurr opened 1 year ago

byBlurr commented 1 year ago

RPM lights flash yellow if the limiter is enabled. flashes on for half second, off for half second.

I have tested this by reverting if (!(ir_EngineWarnings.getInt() & irsdk_pitSpeedLimiter)) but have not tested it by enabling the pit limiter in sim. I do not have access to my pc with iRacing installed. Please test that the if statement works when enabling/disabling the limiter in sim. If it doesn't, then OverlayDDU.h line 261 needs looking into. If there are any other issues, I can look into them.

lespalt commented 1 year ago

I think I played around with irsdk_pitSpeedLimiter back then trying to do something similar, but it didn't quite work the way I expected. Please let me know once someone has had the chance to test this and I'll be happy to review/merge.

byBlurr commented 1 year ago

I also committed a small change adding a lap counter to the standings overlay. So this PR also covers issue #9

byBlurr commented 1 year ago

I am having no luck with fixing my issue #22... I am unable to diagnose it and therefor unable to test any features. I will leave it as is for now for someone else to test before I make any further changes.

byBlurr commented 1 year ago

This pull request now also includes the commit 8a9221c which fixes issue #14 (thanks to them for fixing it but not creating a pull request).

I have tested the pit limiter now and everything is working as expected. Tested in 60Hz and 30Hz mode.

byBlurr commented 1 year ago

Should be good for this pr to be merged. Will close issues #18 #9 and #14

byBlurr commented 1 year ago

a4d3118 reverts laps on leaderboard, as this would create a conflict with the @frmjar fork.